adafruit / Adafruit-MLX90614-Library

Arduino library for the MLX90614 sensors in the Adafruit shop
Other
128 stars 97 forks source link

add new files and create new functions #19

Open Geniezito opened 3 years ago

Geniezito commented 3 years ago

I attach the library folder with the described settings adjust_Adafruit_MLX90614_Library.zip

evaherrada commented 3 years ago

@ladyada I'd be willing to review this if you want me to, but I don't think I'd be able to comment on anything other than documentation changes since I don't really know C++

evaherrada commented 3 years ago

@Geniezito Hey! What GitHub Actions is currently failing on is the clang-format check. You can find out how to run that here: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format

If you have any questions about doing that, or you find anything confusing, let me know. I just added that page to the guide, so it'd be good to know if there's anything confusing or unclear in it.

Thanks!

Geniezito commented 3 years ago

Thanks for your help, the truth is that although I know the C ++ language, I have not practiced it for many years and these adjustments that are required for the library are new to me. I will try to do what is in your guide and if I definitely cannot, I will write to you by this means to ask for your help. thank you

El mié, 2 dic 2020 a las 17:19, Dylan Herrada (notifications@github.com) escribió:

@Geniezito https://github.com/Geniezito Hey! What GitHub Actions is currently failing on is the clang-format check. You can find out how to run that here: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format

If you have any questions about doing that, or you find anything confusing, let me know. I just added that page to the guide, so it'd be good to know if there's anything confusing or unclear in it.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit-MLX90614-Library/pull/19#issuecomment-737530224, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR45E75VOTJXWRX4RZ5NUBTSS24QHANCNFSM4UFDKD2A .

--


"Dios nos Libre de los Ingenieros"

Geniezito commented 3 years ago

Definitely couldn't, I'd appreciate if you could give me a hand with this setting.

caternuson commented 3 years ago

There's some info on installing and running clang-format here: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format

caternuson commented 3 years ago

Can you provide more information on this:

The third allows to preset an adjustment value for the temperature obtained, since these sensors must be frequently calibrated to accept their use in some scenarios,

The correction looks likes a simple offset. Can you provide an example of how one would determine that value?

Geniezito commented 3 years ago

Dear, caternuson:

in reference to your question:

**_Can you provide more information on this:

The third allows to preset an adjustment value for the temperature obtained, since these sensors must be frequently calibrated to accept their use in some scenarios,

The correction looks likes a simple offset. Can you provide an example of how one would determine that value?_**

https://github.com/adafruit/Adafruit-MLX90614-Library/pull/19#issuecomment-774200899

From the point of view of health services, this type of thermometer must be periodically calibrated, to verify that its readings conform to real data, for this, they take as a reference readings from analog thermometers, or digital thermometers with certified calibration.

In terms of the sensor, it is simply to adjust an offset, as you say, however, the person in charge of quality control of the device must take that control, so that when the adjustment requires a very high offset, the use of the device is not allowed or it is recommended to change the sensor.

This is why it is quite important to be able to access the adjustment of that simple offset

ladyada commented 3 years ago

the offset should be initialized to zero and should apply to all unit readings