adafruit / Adafruit-PCD8544-Nokia-5110-LCD-library

Arduino driver for PC8544, most commonly found in small Nokia 5110's
http://ladyada.net/products/nokia5110/
Other
396 stars 226 forks source link

Added support for ESP8266 boards #35

Closed xmichael closed 5 years ago

xmichael commented 8 years ago

Added support for ESP8266 boards like Adafruit HUZZAH. Works out of the box with vanilla Adafruit-GFX.

mcauser commented 8 years ago

This does not work on my WeMos D1 Mini (ESP-12F) on Arduino ESP8266 2.0.0 May be fixed in 2.1.0: https://github.com/esp8266/Arduino/issues/1110

Makuna commented 8 years ago

Is there a reason this is not merged in? I don't understand since Adafruit also sells a esp8266 board? I would change and use the more standard ARDUINO_ARCH_ESP8266 instead of ESP8266; but both work.

mcauser commented 8 years ago

I think they are more busy working on new products than maintaining very old products, which makes business sense. If the open source community are going to help by adding features or adding support/compatibility for other Adafruit products, they could at least have a look at the PRs or if they are too busy, perhaps enlist help from the community. Perhaps raising this in the Adafruit Forums may have more traction than here.

If you are Adafruit staff, thanks for the great libraries. Let us help improve them!

drak7 commented 5 years ago

Closed in favor of #47