search

adafruit / Adafruit-PN532

Arduino library for SPI and I2C access to the PN532 RFID/Near Field Communication chip
Other
422 stars 266 forks source link

Backdoor Commands for Chinese Mifare tags #94

Open SigmaDolphin opened 3 years ago

SigmaDolphin commented 3 years ago

-This change would add support to the library to unlock the backdoor of special Mifare tags that allow for reading and writing any block without authenticating

-It shouldn't affect any already existing platforms, just adding more functionality to them

-I already tested the code and it works correctly, it detects when the tag responds to the special commands or not

Thank you for considering my pull request, i hope the functionality of these tags is added even if my pull request is rejected!

ladyada commented 3 years ago

neat (or not-so-neat i guess it depends on what security you expected :)

SigmaDolphin commented 3 years ago

I mean, they are unsecure by design, haha These kind of tags are meant to be used for cloning tags since you can also write to block 0

also, sorry about missing the Doxygen thing, I don't really know how it works

ladyada commented 3 years ago

heres a guide on doxygen, it is very easy! https://learn.adafruit.com/the-well-automated-arduino-library/doxygen

SigmaDolphin commented 3 years ago

I still don't quite understand In the log here, I see a ton of "Warning"s saying that a lot of the .h file isn't documented, but that's just how the files were in the first place, the only instance I can find in the Doxygen log of my additions is one of the declaration in the .h file, like all of the declarations in the .h file I did took my time to document the functions I added in the .cpp file and they indeed don't appear in the log

ladyada commented 3 years ago

all good!

SigmaDolphin commented 3 years ago

oh, ok, thank you for letting me know its all good then!