Add new functions from v2.2.0 to the Keywords

adafruit / Adafruit-PWM-Servo-Driver-Library

Adafruit PWM Servo Driver Library

Other

477 stars 311 forks source link

Add new functions from v2.2.0 to the Keywords #68

Closed photodude closed 5 years ago

photodude commented 5 years ago

Describe the scope of your change Adds the following to the Keywords for Arduino syntax highlighting
setOscillatorFrequency
getOscillatorFrequency
FREQUENCY_OSCILLATOR
Describe any known limitations with your change.
All library constants are not included
Please run any tests or examples that can exercise your modified code. Tests are not needed as this is only syntax highlighting, Files like this should be inspected to ensure that only a single tab is used between the keyword and the constant identifier

ladyada commented 5 years ago

yay thanks!

photodude commented 5 years ago

@ladyada you are welcome.

photodude commented 5 years ago

@siddacious I saw you pushed a new minor release 2.3.0 from this. I'm not sure why this justified a minor release, under Semantic Versioning 2.0.0 I believe this would have only justified a patch as this was only a bug fix for the IDE syntax highlighting. Do you follow a different convention for versioning?

Our project tracks the version of this library as we have to wrap this library to make our project work correctly. We need to make sure we know what to expect when the major.minor.patch numbers change.

siddacious commented 5 years ago

@photodude my apologies; I'm responsible for releasing most/nearly all of our libs and didn't dig deep enough to recognize that it was more of a patch.

Your contributions are appreciated; I'll be more mindful in the future, though any hints you can pass my way in the commit messages would be helpful.