search

adafruit / Adafruit-SSD1331-OLED-Driver-Library-for-Arduino

For 0.96" OLEDs in the Adafruit shop
http://www.adafruit.com/products/684
Other
100 stars 67 forks source link

Add pins numbers for ESP8266 and make sure demo runs forever #25

Closed marcmerlin closed 5 years ago

ladyada commented 5 years ago

heya thanks - there's infinite different pinout setups, we dont want to have anything but the most basic setup here - for ESP folks, they'd need to look at their board and pick the best pin options!

marcmerlin commented 5 years ago

Fair enough @ladyada . I thought adding more working default pins saved people time or picking the wrong pins and doing swSPI by mistake instead of hwSPI, but your call. I realize it's bad practise to send 2 things in one CL, but maybe you'll consider moving the code from setup() to loop() so that it runs forever instead of stopping after one run?

ladyada commented 5 years ago

i think lets keep this demo as is, it doesn't have a lot of benefit to run repeatedly and it hasn't been an issue

marcmerlin commented 5 years ago

understood, thanks for getting back to me.