search

adafruit / Adafruit-ST7735-Library

This is a library for the Adafruit 1.8" SPI display http://www.adafruit.com/products/358 and http://www.adafruit.com/products/618
https://learn.adafruit.com/1-8-tft-display
565 stars 305 forks source link

offset issue with 1.14" 240x135 color TFT #137

Closed centimeter closed 3 years ago

centimeter commented 3 years ago

Hi, as of the newest update (1.7.0) the library offsets everything on the 1.14" TFTs. (image displaces near the center of the screen, offset by static on the left and top) Looking at the library, I think this might be due to commit 2de13766b51a2b285d18150ce4903ae7dc0f9a9d, which added another if statement for another display size, but now may incorrectly set the offset for the 1.14" screens (which are 240x135)?

I'm sadly a meche student and don't have other displays to test/am not confident/skilled enough to like, actually change the code and am just rolling back for the time being but it seems like a potentially easy fix? Apologies if this is a misuse of an issue haha.

makermelissa commented 3 years ago

I see. It should probably be an else if statement instead of separate if and if else statements. Want to submit a pull request?

makermelissa commented 3 years ago

Actually, it's quick, so I'll do it.