search

adafruit / Adafruit-ST7735-Library

This is a library for the Adafruit 1.8" SPI display http://www.adafruit.com/products/358 and http://www.adafruit.com/products/618
https://learn.adafruit.com/1-8-tft-display
578 stars 308 forks source link

Ability to change BGR / RGB method (for some AliExpress INITR_GREENTAB models) #154

Open simkard69 opened 3 years ago

simkard69 commented 3 years ago

Hello,

I bought the following screen on AliExpress (but can be found anywhere nowadays) : image

Seems like the RGB coding that this screen expects is ST77XX_MADCTL_RGB instead of ST7735_MADCTL_BGR Initializing it with BLACKTAB works for color but gets bottom and right edges wrong. Initializing it with GREENTAB works for edges but not for colors

Seems like people are referring to these screens as YELLOWTAB ... anyway these ones seem to be a little bit annoying to use.

In order to solve out the problem I had to modify the library file "Adafruit_ST7735.cpp" and change these lines :

... switch (rotation) { case 0: if ((tabcolor == INITR_BLACKTAB) || (tabcolor == INITR_MINI160x80)) { madctl = ST77XX_MADCTL_MX | ST77XX_MADCTL_MY | ST77XX_MADCTL_RGB; } else { // madctl = ST77XX_MADCTL_MX | ST77XX_MADCTL_MY | ST7735_MADCTL_BGR; madctl = ST77XX_MADCTL_MX | ST77XX_MADCTL_MY | ST77XX_MADCTL_RGB; } ... case 1: if ((tabcolor == INITR_BLACKTAB) || (tabcolor == INITR_MINI160x80)) { madctl = ST77XX_MADCTL_MY | ST77XX_MADCTL_MV | ST77XX_MADCTL_RGB; } else { // madctl = ST77XX_MADCTL_MY | ST77XX_MADCTL_MV | ST7735_MADCTL_BGR; madctl = ST77XX_MADCTL_MY | ST77XX_MADCTL_MV | ST77XX_MADCTL_RGB; } ... case 2: if ((tabcolor == INITR_BLACKTAB) || (tabcolor == INITR_MINI160x80)) { madctl = ST77XX_MADCTL_RGB; } else { // madctl = ST7735_MADCTL_BGR; madctl = ST77XX_MADCTL_RGB; } ... case 3: if ((tabcolor == INITR_BLACKTAB) || (tabcolor == INITR_MINI160x80)) { madctl = ST77XX_MADCTL_MX | ST77XX_MADCTL_MV | ST77XX_MADCTL_RGB; } else { // madctl = ST77XX_MADCTL_MX | ST77XX_MADCTL_MV | ST7735_MADCTL_BGR; madctl = ST77XX_MADCTL_MX | ST77XX_MADCTL_MV | ST77XX_MADCTL_RGB; ...

Adafruit_ST7735.zip

theloukou commented 2 years ago

Hey, please try out my forked library version, it should be working with your screen (use init INITR_GREENTAB_WS) If so, leave a note on PR #168 to confirm it works correctly.

IAmOrion commented 2 years ago

+1 - I have this exact same issue and came across this issue searching a way to change the RGB/BGR method at runtime rather than having to edit the libraries. Would be nice for a GREENTAB with RGB as an option (So GREENTAB col/row stuff with BLACKTAB colour profile)

theloukou commented 2 years ago

Hey @IAmOrion, please try my forked version if you haven't already. If everything is OK to you as well, post a comment or something in PR #168, maybe someday someone will see them :P

IAmOrion commented 2 years ago

Hey @IAmOrion, please try my forked version if you haven't already. If everything is OK to you as well, post a comment or something in PR #168, maybe someday someone will see them :P

I got mine working by just modding the library to be RGB with green tab instead BGR but yes, it would be nice if they could pull in the fixes