search

adafruit / Adafruit-ST7735-Library

This is a library for the Adafruit 1.8" SPI display http://www.adafruit.com/products/358 and http://www.adafruit.com/products/618
https://learn.adafruit.com/1-8-tft-display
565 stars 305 forks source link

Some screens have non-standard col/row start values #66

Closed BalintCsala closed 5 years ago

BalintCsala commented 5 years ago

I received a 1.8" 128x160 LCD from China (ST7735) and tried using the library, but it missed a couple of pixels around the edges (2 rows and 1 column on the top and right sides respectively).

I tried using every possible value in initR, but it either left the same edges or the colors were off.

To solve this issue I made "setColRowStart" public and set the values to 2 and 1.

I'm curious why this function isn't public to begin with. It could solve problems like this very easily.

ladyada commented 5 years ago

mostly for back compatability, you should make a new type or subclass for your display! :)

LONGACAT commented 5 years ago

I have found out that this lcd does have exactly the same issue. Is it okay if I add it to initR and make a PR?

BalintCsala commented 5 years ago

This may be due to the driver being ST7735S not just simply ST7735. Mine has that driver too

ladyada commented 5 years ago

fixed most likely