adafruit / Adafruit-ST7735-Library

This is a library for the Adafruit 1.8" SPI display http://www.adafruit.com/products/358 and http://www.adafruit.com/products/618
https://learn.adafruit.com/1-8-tft-display
565 stars 305 forks source link

Support Feather Huzzah32 in Examples #98

Closed eppfel closed 4 years ago

eppfel commented 4 years ago

Running the examples e.g. graphicstest does not support Feather Huzzah since [this commit to support ESP32](https://github.com/adafruit/Adafruit-ST7735- Library/commit/7fcfad917036f5b3c1336386f0a12f18127c244c) makes it impossible to wire the Huzzah32 in a way the examples can be run without modifying the CS, DC and Reset pins in the code.

In particular, I just confirmed that the condition #elif defined(ESP32) catches the feather huzzah32 as well. This is in conflict with the Feather as GIOP 5 is SCK on the feather, which means you cannot wire it in a way that these tests would work. I know it is not hard to change three Pins in the code but it is also not optimal.

I would make a pull request but I'm unsure about best practice here. Comment about Huzzah32 at the indicated line? Adding another case?

eppfel commented 4 years ago

Thanks. 👍