Open NickWaterton opened 8 years ago
flexil
commented
5 years ago i am currently working on tge vc0706 i found that the microcontroller read the version of the camera but there is a little bug in the code it should be if (reply<o){ Serial.print("failed to get the version")} else {Serial.print('reply')}
flexil
commented
5 years ago though still i get failed to snap
NickWaterton
commented
5 years ago There are several bugs in the Adafruit library, the init command is wrong as far as I recall, what you check as a response to the init command is actually the output of the power up reset.
I did fix all the bugs long ago, I’ll have to look and see where I put the fixed library.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:03 PM, flexil notifications@github.com<mailto:notifications@github.com> wrote:
though still i get failed to snap
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442278550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ5qrqqY_p7liVjUynlFTNfgSA_YFks5uzeDmgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
flexil
commented
5 years ago I would appreciate if you send it to me. I get stuck and don't know what to do. I do want to make it work.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com Sent: Wednesday, November 28, 2018 1:13:53 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
There are several bugs in the Adafruit library, the init command is wrong as far as I recall, what you check as a response to the init command is actually the output of the power up reset.
I did fix all the bugs long ago, I’ll have to look and see where I put the fixed library.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:03 PM, flexil notifications@github.com<mailto:notifications@github.com> wrote:
though still i get failed to snap
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442278550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ5qrqqY_p7liVjUynlFTNfgSA_YFks5uzeDmgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442280488, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPSuycc4D6fU2iARCdusVUGZIrY9yks5uzeNRgaJpZM4HqG0Q.
NickWaterton
commented
5 years ago Just took a quick look, it’s actually the get version command that is wrong. There may be other errors I fixed as well.
Here is the fixed get version.
/***** other high level commands */
char * Adafruit_VC0706::getVersion(void) { uint8_t args[] = {0x00}; //was 0x01 but this seems wrong!
sendCommand(VC0706_GEN_VERSION, args, 1); // get reply if (!readResponse(CAMERABUFFSIZ, 200)) return 0; camerabuff[bufferLen] = 0; // end it! return (char *)camerabuff+5; // return it! - No! add 5 to it (response should be 0 x76+Serial number+0x11+0x00+0x0B+"VC0706 1.00") serial number = 0x00 }
I’ll try to upload the whole library tomorrow.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:20 PM, flexil notifications@github.com<mailto:notifications@github.com> wrote:
I would appreciate if you send it to me. I get stuck and don't know what to do. I do want to make it work.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, November 28, 2018 1:13:53 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
There are several bugs in the Adafruit library, the init command is wrong as far as I recall, what you check as a response to the init command is actually the output of the power up reset.
I did fix all the bugs long ago, I’ll have to look and see where I put the fixed library.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:03 PM, flexil notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> wrote:
though still i get failed to snap
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442278550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ5qrqqY_p7liVjUynlFTNfgSA_YFks5uzeDmgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442280488, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPSuycc4D6fU2iARCdusVUGZIrY9yks5uzeNRgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442281711, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ7DnDiBo6cYZUDgM-pPbXuMIerGdks5uzeTQgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
flexil
commented
5 years ago Thank you sir. I am modifying the .cpp as you did. Thanks for your assistance. I eagerly await your response tomorrow.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com Sent: Wednesday, November 28, 2018 1:32:35 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Just took a quick look, it’s actually the get version command that is wrong. There may be other errors I fixed as well.
Here is the fixed get version.
/***** other high level commands */
char * Adafruit_VC0706::getVersion(void) { uint8_t args[] = {0x00}; //was 0x01 but this seems wrong!
sendCommand(VC0706_GEN_VERSION, args, 1); // get reply if (!readResponse(CAMERABUFFSIZ, 200)) return 0; camerabuff[bufferLen] = 0; // end it! return (char *)camerabuff+5; // return it! - No! add 5 to it (response should be 0 x76+Serial number+0x11+0x00+0x0B+"VC0706 1.00") serial number = 0x00 }
I’ll try to upload the whole library tomorrow.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:20 PM, flexil notifications@github.com<mailto:notifications@github.com> wrote:
I would appreciate if you send it to me. I get stuck and don't know what to do. I do want to make it work.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, November 28, 2018 1:13:53 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
There are several bugs in the Adafruit library, the init command is wrong as far as I recall, what you check as a response to the init command is actually the output of the power up reset.
I did fix all the bugs long ago, I’ll have to look and see where I put the fixed library.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:03 PM, flexil notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> wrote:
though still i get failed to snap
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442278550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ5qrqqY_p7liVjUynlFTNfgSA_YFks5uzeDmgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442280488, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPSuycc4D6fU2iARCdusVUGZIrY9yks5uzeNRgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442281711, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ7DnDiBo6cYZUDgM-pPbXuMIerGdks5uzeTQgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442284261, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPU8gnaYemgAdL9-fBL02C32SBbEkks5uzeezgaJpZM4HqG0Q.
flexil
commented
5 years ago Good day Nick,
Please i would like to check whether you are able to upload the vc0706 library. I am still knocking my head on it.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com Sent: Wednesday, November 28, 2018 1:32:35 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Just took a quick look, it’s actually the get version command that is wrong. There may be other errors I fixed as well.
Here is the fixed get version.
/***** other high level commands */
char * Adafruit_VC0706::getVersion(void) { uint8_t args[] = {0x00}; //was 0x01 but this seems wrong!
sendCommand(VC0706_GEN_VERSION, args, 1); // get reply if (!readResponse(CAMERABUFFSIZ, 200)) return 0; camerabuff[bufferLen] = 0; // end it! return (char *)camerabuff+5; // return it! - No! add 5 to it (response should be 0 x76+Serial number+0x11+0x00+0x0B+"VC0706 1.00") serial number = 0x00 }
I’ll try to upload the whole library tomorrow.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:20 PM, flexil notifications@github.com<mailto:notifications@github.com> wrote:
I would appreciate if you send it to me. I get stuck and don't know what to do. I do want to make it work.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, November 28, 2018 1:13:53 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
There are several bugs in the Adafruit library, the init command is wrong as far as I recall, what you check as a response to the init command is actually the output of the power up reset.
I did fix all the bugs long ago, I’ll have to look and see where I put the fixed library.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:03 PM, flexil notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> wrote:
though still i get failed to snap
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442278550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ5qrqqY_p7liVjUynlFTNfgSA_YFks5uzeDmgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442280488, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPSuycc4D6fU2iARCdusVUGZIrY9yks5uzeNRgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442281711, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ7DnDiBo6cYZUDgM-pPbXuMIerGdks5uzeTQgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442284261, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPU8gnaYemgAdL9-fBL02C32SBbEkks5uzeezgaJpZM4HqG0Q.
NickWaterton
commented
5 years ago Sorry, I forgot. I have attached it here.
Nick Waterton P.Eng. National Support Leader - Nuclear Medicine, PET and RP GE Healthcare
M+1 416 859 8545 E nick.waterton@med.ge.commailto:nick.waterton@med.ge.com
2300 Meadowvale Boulevard Mississauga, ON L5N 5P9 Canada
GE imagination at work
From: flexil notifications@github.com Sent: Wednesday, November 28, 2018 6:25 PM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Adafruit-VC0706-Serial-Camera-Library@noreply.github.com Cc: Waterton, Nick (GE Healthcare) Nick.Waterton@med.ge.com; Author author@noreply.github.com Subject: EXT: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Good day Nick,
Please i would like to check whether you are able to upload the vc0706 library. I am still knocking my head on it.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, November 28, 2018 1:32:35 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Just took a quick look, it’s actually the get version command that is wrong. There may be other errors I fixed as well.
Here is the fixed get version.
/***** other high level commands */
char * Adafruit_VC0706::getVersion(void) { uint8_t args[] = {0x00}; //was 0x01 but this seems wrong!
sendCommand(VC0706_GEN_VERSION, args, 1); // get reply if (!readResponse(CAMERABUFFSIZ, 200)) return 0; camerabuff[bufferLen] = 0; // end it! return (char *)camerabuff+5; // return it! - No! add 5 to it (response should be 0 x76+Serial number+0x11+0x00+0x0B+"VC0706 1.00") serial number = 0x00 }
I’ll try to upload the whole library tomorrow.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:20 PM, flexil notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> wrote:
I would appreciate if you send it to me. I get stuck and don't know what to do. I do want to make it work.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> Sent: Wednesday, November 28, 2018 1:13:53 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
There are several bugs in the Adafruit library, the init command is wrong as far as I recall, what you check as a response to the init command is actually the output of the power up reset.
I did fix all the bugs long ago, I’ll have to look and see where I put the fixed library.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:03 PM, flexil notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.com> wrote:
though still i get failed to snap
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442278550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ5qrqqY_p7liVjUynlFTNfgSA_YFks5uzeDmgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442280488, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPSuycc4D6fU2iARCdusVUGZIrY9yks5uzeNRgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442281711, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ7DnDiBo6cYZUDgM-pPbXuMIerGdks5uzeTQgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442284261, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPU8gnaYemgAdL9-fBL02C32SBbEkks5uzeezgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442645056, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ_TPKQHqu4G2m1FJIAdM5k7cuY9Zks5uzxtdgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
flexil
commented
5 years ago Please i didn't see the attached file.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com Sent: Thursday, November 29, 2018 2:46:35 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Sorry, I forgot. I have attached it here.
Nick Waterton P.Eng. National Support Leader - Nuclear Medicine, PET and RP GE Healthcare
M+1 416 859 8545 E nick.waterton@med.ge.commailto:nick.waterton@med.ge.com
2300 Meadowvale Boulevard Mississauga, ON L5N 5P9 Canada
GE imagination at work
From: flexil notifications@github.com Sent: Wednesday, November 28, 2018 6:25 PM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Adafruit-VC0706-Serial-Camera-Library@noreply.github.com Cc: Waterton, Nick (GE Healthcare) Nick.Waterton@med.ge.com; Author author@noreply.github.com Subject: EXT: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Good day Nick,
Please i would like to check whether you are able to upload the vc0706 library. I am still knocking my head on it.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, November 28, 2018 1:32:35 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Just took a quick look, it’s actually the get version command that is wrong. There may be other errors I fixed as well.
Here is the fixed get version.
/***** other high level commands */
char * Adafruit_VC0706::getVersion(void) { uint8_t args[] = {0x00}; //was 0x01 but this seems wrong!
sendCommand(VC0706_GEN_VERSION, args, 1); // get reply if (!readResponse(CAMERABUFFSIZ, 200)) return 0; camerabuff[bufferLen] = 0; // end it! return (char *)camerabuff+5; // return it! - No! add 5 to it (response should be 0 x76+Serial number+0x11+0x00+0x0B+"VC0706 1.00") serial number = 0x00 }
I’ll try to upload the whole library tomorrow.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:20 PM, flexil notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> wrote:
I would appreciate if you send it to me. I get stuck and don't know what to do. I do want to make it work.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> Sent: Wednesday, November 28, 2018 1:13:53 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
There are several bugs in the Adafruit library, the init command is wrong as far as I recall, what you check as a response to the init command is actually the output of the power up reset.
I did fix all the bugs long ago, I’ll have to look and see where I put the fixed library.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:03 PM, flexil notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.com> wrote:
though still i get failed to snap
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442278550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ5qrqqY_p7liVjUynlFTNfgSA_YFks5uzeDmgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442280488, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPSuycc4D6fU2iARCdusVUGZIrY9yks5uzeNRgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442281711, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ7DnDiBo6cYZUDgM-pPbXuMIerGdks5uzeTQgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442284261, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPU8gnaYemgAdL9-fBL02C32SBbEkks5uzeezgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442645056, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ_TPKQHqu4G2m1FJIAdM5k7cuY9Zks5uzxtdgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442686257, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPeBOFUYL6KG9Ev5EVUsS34nXiYJXks5uz0qLgaJpZM4HqG0Q.
flexil
commented
5 years ago Please i didn't see the attached the file
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com Sent: Thursday, November 29, 2018 2:46:35 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Sorry, I forgot. I have attached it here.
Nick Waterton P.Eng. National Support Leader - Nuclear Medicine, PET and RP GE Healthcare
M+1 416 859 8545 E nick.waterton@med.ge.commailto:nick.waterton@med.ge.com
2300 Meadowvale Boulevard Mississauga, ON L5N 5P9 Canada
GE imagination at work
From: flexil notifications@github.com Sent: Wednesday, November 28, 2018 6:25 PM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Adafruit-VC0706-Serial-Camera-Library@noreply.github.com Cc: Waterton, Nick (GE Healthcare) Nick.Waterton@med.ge.com; Author author@noreply.github.com Subject: EXT: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Good day Nick,
Please i would like to check whether you are able to upload the vc0706 library. I am still knocking my head on it.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, November 28, 2018 1:32:35 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
Just took a quick look, it’s actually the get version command that is wrong. There may be other errors I fixed as well.
Here is the fixed get version.
/***** other high level commands */
char * Adafruit_VC0706::getVersion(void) { uint8_t args[] = {0x00}; //was 0x01 but this seems wrong!
sendCommand(VC0706_GEN_VERSION, args, 1); // get reply if (!readResponse(CAMERABUFFSIZ, 200)) return 0; camerabuff[bufferLen] = 0; // end it! return (char *)camerabuff+5; // return it! - No! add 5 to it (response should be 0 x76+Serial number+0x11+0x00+0x0B+"VC0706 1.00") serial number = 0x00 }
I’ll try to upload the whole library tomorrow.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:20 PM, flexil notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> wrote:
I would appreciate if you send it to me. I get stuck and don't know what to do. I do want to make it work.
Kind regards, Flexil.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> Sent: Wednesday, November 28, 2018 1:13:53 AM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
There are several bugs in the Adafruit library, the init command is wrong as far as I recall, what you check as a response to the init command is actually the output of the power up reset.
I did fix all the bugs long ago, I’ll have to look and see where I put the fixed library.
Nick Waterton P.Eng Sent from my iPhone
On Nov 27, 2018, at 8:03 PM, flexil notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>mailto:notifications@github.com> wrote:
though still i get failed to snap
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442278550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ5qrqqY_p7liVjUynlFTNfgSA_YFks5uzeDmgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442280488, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPSuycc4D6fU2iARCdusVUGZIrY9yks5uzeNRgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442281711, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ7DnDiBo6cYZUDgM-pPbXuMIerGdks5uzeTQgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442284261, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPU8gnaYemgAdL9-fBL02C32SBbEkks5uzeezgaJpZM4HqG0Q.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442645056, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCUZ_TPKQHqu4G2m1FJIAdM5k7cuY9Zks5uzxtdgaJpZM4HqG0Q.
Unsubscribe from GE's commercial electronic messages: http://sc.ge.com/*casl-unsubscribe Désabonner des messages électroniques commerciaux de GE: http://sc.ge.com/*lcap-desabonnement
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442686257, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPeBOFUYL6KG9Ev5EVUsS34nXiYJXks5uz0qLgaJpZM4HqG0Q.
NickWaterton
commented
5 years ago OK, Try this. Adafruit-VC0706.zip
flexil
commented
5 years ago Just saw the mail. I try it today and revert back to you. Thank you.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Nick Waterton notifications@github.com Sent: Thursday, November 29, 2018 9:27:56 PM To: adafruit/Adafruit-VC0706-Serial-Camera-Library Cc: flexil; Comment Subject: Re: [adafruit/Adafruit-VC0706-Serial-Camera-Library] GetVersion() command is incorrect (#12)
OK, Try this. Adafruit-VC0706.ziphttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/files/2630926/Adafruit-VC0706.zip
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/adafruit/Adafruit-VC0706-Serial-Camera-Library/issues/12#issuecomment-442999451, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaJmPWCJsnSb4sbTvzBb7dBekW-meco5ks5u0FFcgaJpZM4HqG0Q.
I noticed when using this library, that when starting up, the getVersion() command (after begin) actually returns the power up string, not the version number.
Looking into it, I found a couple of bugs.
Begin() actually does a reset, but does not flush the serial buffer -that's why getVersion() after begin() returns the power on text.
GetVersion() itself is broken, you just get "v" and some hex from it (which probably means something). The solution for getVersion is to change the arg 0x01 to 0x00 (this is the correct value), and the return (char *) camerabuf should be camerabuf+5. I'm actually not sure what 0x01 in getVersion does (documentation says it should be 0x00).
This gives the correct version string.
You can then use this to find what baud rate the camera is running at. If you don't use begin() you can set the camera to whatever baud rate you want.
As to the begin/reset issue -don't use begin, just use the underlying serial commands (swser.begun(baud)), swser.flush() etc.) that's all begin does anyway. Use cam.reset() if you want a reset - no need to hide one in begin.
Oh, no header guards either.