Add data rate and remove fixed conversion delay

adafruit / Adafruit_ADS1X15

Driver for TI's ADS1015: 12-bit Differential or Single-Ended ADC with PGA and Comparator

Other

289 stars 301 forks source link

Add data rate and remove fixed conversion delay #59

Closed caternuson closed 3 years ago

caternuson commented 3 years ago

Two things here:

replace fixed conversion delay with a wait-for-conversion polling loop
add ability to get/set data rate

caternuson commented 3 years ago

I forgot to bump version, but I'm hoping/planning to just release all these as one mega 2.x release anyway, and will make sure library.properties makes sense at that point. Maybe even just roll it back to 2.0.0 for actual release.

soligen2010 commented 3 years ago

I see you are making a lot of improvements and seem, to be committed to a major overhaul. I'd like to suggest you also take a look at the soligen2010 fork, where I make a lot of improvements too. For some reason these were lever merged, but I think they deserve to be in the main fork, so maybe this is a resource you can use.

https://github.com/soligen2010/Adafruit_ADS1X15

caternuson commented 3 years ago

@soligen2010 Yep, thanks. You did a lot of good contributions here. Nothing really wrong with them, just got overlooked.