This PR fixes a stupid mistake I missed in my last PR, that mistake being that I forgot to actually calculate the angles in getGravityVector.
I thought of that when planning this, so idk how I forgot.
I did do significant testing, but it seems like I didn't do any testing that doesn't use roll, pitch, and yaw at all.
Changes
Fix getGravityVector not actually calculating any values
Change angelsComputed to a bool
Questions
Is there a good reason for anglesComputed to be a char rather then a bool? I did some research and couldn't find one, but if there is I will undo that.
Is there a framework to add CI tests other then build tests with?
I know that platformio has the ci command, however I have never used that so I don't really know what that does.
Also adafruit doesn't seem to use platformio, so would that even be wanted?
ladyada
commented
2 years ago
This PR fixes a stupid mistake I missed in my last PR, that mistake being that I forgot to actually calculate the angles in getGravityVector.
I thought of that when planning this, so idk how I forgot. I did do significant testing, but it seems like I didn't do any testing that doesn't use roll, pitch, and yaw at all.
Changes
Questions