search

adafruit / Adafruit_APDS9960

Arduino drivers for APDS9960 gesture sensor
Other
37 stars 45 forks source link

re-add bytesRead #17

Closed szymonkaliski closed 5 years ago

szymonkaliski commented 5 years ago

Per this comment https://github.com/adafruit/Adafruit_APDS9960/commit/bc9b9c2f177959e722efb4a2e54c6b54dda2ac9b#commitcomment-32102305

ladyada commented 5 years ago

thanx - did you run the hardware test after the PR? if not, lets add that to the workflow!

szymonkaliski commented 5 years ago

Hmm, I believe I didn't have the hardware when I was working on this lib at the beginning, and that introduced the bug, that this PR is (hopefully) solving — this PR is s a "hotfix", didn't test though yet.

ladyada commented 5 years ago

fixed travis - this still needs a hardware test - @hoffmannjan will do it after the next library :)

ladyada commented 5 years ago

@szymonkaliski @hoffmannjan please bump this to a bugfix release so it goes out!

hoffmannjan commented 5 years ago

this is done