adafruit / Adafruit_Adalink

Python wrapper for Segger's J-Link Commander & STMicro STLink V2 to flash various ARM MCUs
MIT License
125 stars 33 forks source link

Missing hex file errors get swallowed #2

Closed microbuilder closed 9 years ago

microbuilder commented 9 years ago

If you sent a list of .hex files to AdaLink and one or more of the files are missing, it will fail silently but it will look like everything flashed OK.

Perhaps we should check if the files actually exist before calling JLinkExe to make sure the really exist, and throwing an appropriate error? Most people won't run in --verbose mode to read the output to catch the error.

tdicola commented 9 years ago

Oh good catch! Let me take a look and fix it up today.

On Thu, May 7, 2015 at 8:35 AM, Kevin Townsend notifications@github.com wrote:

If you sent a list of .hex files to AdaLink and one or more of the files are missing, it will fail silently but it will look like everything flashed OK.

Perhaps we should check if the files actually exist before calling JLinkExe to make sure the really exist, and throwing an appropriate error? Most people won't run in --verbose mode to read the output to catch the error.

— Reply to this email directly or view it on GitHub https://github.com/adafruit/Adafruit_Adalink/issues/2.