search

adafruit / Adafruit_BLESniffer_Python

Python API for Adafruit's Bluefruit LE Sniffer
Other
101 stars 51 forks source link

add Python 3 support #17

Closed speidy closed 6 years ago

speidy commented 6 years ago

This PR adds Python 3 support with backwards compatibility to Python 2.

Also iv'e applied PEP8 fixes and issues raised by Flake8 linter.

ladyada commented 6 years ago

hiya, have you tested with both python2 and python3 and hardware? :)

FYI we're now shipping sniffers that use the new nordic v2 firmware and that has new python code too and guess what, its still python2 :(

speidy commented 6 years ago

@ladyada oh, well i saw the there's a new code from Nordic, can you point me to their repository?

I didn't test that code enough, just a sanity on Windows

ladyada commented 6 years ago

there's no repo i know of, the zip of code is here https://learn.adafruit.com/introducing-the-adafruit-bluefruit-le-sniffer/v2-wireshark-usage

speidy commented 6 years ago

Yea, I got that zip. I have ported that code to python 3 as well.

I don’t find any repo under Nordic github account :/

Is the code in your repo considered deprecated ? Or should be used against old hardware?

בתאריך יום ו׳, 17 באוג׳ 2018 ב-18:11 מאת ladyada notifications@github.com:

there's no repo i know of, the zip of code is here

https://learn.adafruit.com/introducing-the-adafruit-bluefruit-le-sniffer/v2-wireshark-usage

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_BLESniffer_Python/pull/17#issuecomment-413897050, or mute the thread https://github.com/notifications/unsubscribe-auth/ADTH1KnbaXO_6yo-hvzIu5u9ADpJjUf5ks5uRt06gaJpZM4WA7pk .

-- Idan Freiberg

GPG FP: 8108 7EC9 806E 4980 75F2 72B3 8AD3 2D04 337B 1F18

ladyada commented 6 years ago

this code is essentially deprecated, they assume people will use v2 only. we can merge this if its been tested

speidy commented 6 years ago

Let me test it a bit more and then merge. Will update. בתאריך יום ו׳, 17 באוג׳ 2018 ב-22:39 מאת ladyada notifications@github.com:

this code is essentially deprecated, they assume people will use v2 only. we can merge this if its been tested

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_BLESniffer_Python/pull/17#issuecomment-413968820, or mute the thread https://github.com/notifications/unsubscribe-auth/ADTH1IO-5jQWa42ziUX9fbJq7cROZ3Eaks5uRxv2gaJpZM4WA7pk .

-- Idan Freiberg

GPG FP: 8108 7EC9 806E 4980 75F2 72B3 8AD3 2D04 337B 1F18

speidy commented 6 years ago

Ok, tested with Python 2 / 3 and seems to work ok against the Bluefruit LE sniffer.

I think its merge ready.