Fix register defintions.

adafruit / Adafruit_BME280_Library

Arduino Library for BME280 sensors

Other

333 stars 304 forks source link

Fix register defintions. #39

Closed herm closed 5 years ago

herm commented 6 years ago

Fixes #28.

With this patch the sensor finally matches the specs from the datasheet. Before the pressure measurement where much worse because wrong settings were selected.

herm commented 5 years ago

This pull request is open for almost one year. The changes are trivial. Is there anything holding back merging this fix?

ladyada commented 5 years ago

thanks! :)

Ivoz commented 5 years ago

Hi @herm , do you know if the same correction should be made in the BPM280 library?

https://github.com/adafruit/Adafruit_BMP280_Library/blob/ce8d87d3d2569f08ef284477bba1b9db49730f22/Adafruit_BMP280.h#L256-L272

herm commented 5 years ago

Yes, the BMP280 library contains the exact same bug.