search

adafruit / Adafruit_BME280_Library

Arduino Library for BME280 sensors
Other
333 stars 304 forks source link

changed private to protected #47

Closed espHorst closed 5 years ago

espHorst commented 5 years ago

Changed the private methods and attributes to protected. This allows to inherit the class and to reuse all the existing protected methods.

espHorst commented 5 years ago

That was fast. Thanks!

ladyada commented 5 years ago

@espHorst sorry i merged too fast - travis is not passing, please add the documentation strings! https://travis-ci.com/adafruit/Adafruit_BME280_Library/builds/106625130 i

espHorst commented 5 years ago

Hm. Travis seems to throw warnings because of missing documentation for all the members that are now protected. Maybe travis does not request documentation for private members? Now all 27 former private members are protected. I can try to add the documentation, but this will take some time as I have to do some reverse engineering.

ladyada commented 5 years ago

that's right protected are available. please submit another PR to undo this one or i can undo it, so that the builds don't break!

ladyada commented 5 years ago

hiya i reverted this change

espHorst commented 5 years ago

Thanks for reverting. I'm giving it a new try with all doc strings provided. I have created a new PR and I hope travis will work ...