adafruit / Adafruit_BMP280_Library

Arduino Library for BMP280 sensors
253 stars 186 forks source link

Forward declarations and interface reference #25

Closed sslupsky closed 5 years ago

sslupsky commented 5 years ago

When SPI_INTEFACES_COUNT or WIRE_INTERFACES_COUNT is zero, the library fails to compile. A forward declaration is used to fix this.

There is a direct reference to "SPI" where it should be an indirect reference "_spi->".

sslupsky commented 5 years ago

Not sure why there is a check failure? This builds fine in my environment. How do determine what failed?

sslupsky commented 5 years ago

Found the issue: In file included from sketch/bmp280test.ino.cpp:1:0: /home/travis/.arduino15/packages/adafruit/hardware/samd/1.4.1/cores/arduino/Arduino.h:48:17: fatal error: sam.h: No such file or directory

include "sam.h"

This error seems to have something to do with the build for the M4 core. As far as I can tell there are not core dependencies in this library. Maybe Travis CI wasn't set up correctly to build for this core?

makermelissa commented 5 years ago

Usually clearing the Travis cache and re-running fixes this.

sslupsky commented 5 years ago

@makermelissa I am not sure how to do that ... is that something you have to do at your end?

makermelissa commented 5 years ago

I don't think so. Here's how to do it:

  1. Go to the page that shows the errors
  2. Click More Options in the upper right
  3. Clcik Caches
  4. Click the trashcans next to them
  5. Restart the build
sslupsky commented 5 years ago

I only have one option in the "more options" pull down: "Requests"

Screen Shot 2019-05-10 at 1 08 35 PM

makermelissa commented 5 years ago

Ah ok. I guess it was something I had to do. Done.

makermelissa commented 5 years ago

It may have also needed you to sign in for the option to be available.