search

adafruit / Adafruit_Blinka

Add CircuitPython hardware API and libraries to MicroPython & CPython devices
https://learn.adafruit.com/circuitpython-on-raspberrypi-linux
MIT License
453 stars 340 forks source link

remove PWMOut from pulseio #554

Closed dhalbert closed 2 years ago

dhalbert commented 2 years ago
ladyada commented 2 years ago

coral boards do have true PWM out, this doesnt remove support right? https://learn.adafruit.com/circuitpython-on-google-coral-linux-blinka/pwm-outputs-servos

dhalbert commented 2 years ago

coral boards do have true PWM out, this doesnt remove support right? https://learn.adafruit.com/circuitpython-on-google-coral-linux-blinka/pwm-outputs-servos

The PR is just removing pulseio.PWMOut, which was dropped in CPy 7. It leaves pwmio.PWMOut as is.

makermelissa commented 2 years ago

Did we want to remove pulseio completely from here? I noticed it's still there for the Raspberry Pi.

dhalbert commented 2 years ago

Did we want to remove pulseio completely from here? I noticed it's still there for the Raspberry Pi.

It provides pulseio.PulseIn, which is real, I thought. So it's still there, but just for that.

dhalbert commented 2 years ago

I did check the Learn Guide code for uses of pulseio.PWMOut, and didn't find any, which is good.