search

adafruit / Adafruit_Blinka

Add CircuitPython hardware API and libraries to MicroPython & CPython devices
https://learn.adafruit.com/circuitpython-on-raspberrypi-linux
MIT License
439 stars 327 forks source link

New Support for ODROID-M1S #739

Closed how2flow closed 7 months ago

how2flow commented 7 months ago

i2c0, spi and uart are not available as default values because they are provided as aliases.

how2flow commented 7 months ago
how2flow commented 7 months ago

Because you added a new microcontroller, they should be also added to: https://github.com/adafruit/Adafruit_Blinka/blob/main/src/microcontroller/__init__.py https://github.com/adafruit/Adafruit_Blinka/blob/main/src/microcontroller/pin.py

ODROID-M1S is rk3566 SBC. And rk3566 is already included in the code.

https://github.com/adafruit/Adafruit_Blinka/blob/4e29053a25b418de8f3f39fb6d4db9cfc6b23290/src/microcontroller/__init__.py#L108

https://github.com/adafruit/Adafruit_Blinka/blob/4e29053a25b418de8f3f39fb6d4db9cfc6b23290/src/microcontroller/pin.py#L114

how2flow commented 7 months ago

Request review is my mistake..