adafruit / Adafruit_Blinka

Add CircuitPython hardware API and libraries to MicroPython & CPython devices
https://learn.adafruit.com/circuitpython-on-raspberrypi-linux
MIT License
453 stars 340 forks source link

Added support for Olimex A20-LIME2-EMMC Board #743

Closed KingPharoo closed 9 months ago

KingPharoo commented 10 months ago

Modified following https://github.com/adafruit/Adafruit_Python_PlatformDetect/pull/328 pull request. Not all the pins are populated in the LIME2 board. The one I used previously for personal use, had a lot more pins. But obv not all of them were used.

KingPharoo commented 10 months ago

I think this test is failing because the pull request has not been merged and released? I am beginning to understand how all of this works.

makermelissa commented 10 months ago

Correct. :)

KingPharoo commented 10 months ago

okay, hopefully I have done the changes correctly and fixed the reference everywhere.

KingPharoo commented 10 months ago

You are correct, I only changed the name in my installed library to test the changes, but forgot to change in the installation /src/ folder

thank you

KingPharoo commented 9 months ago

Oh man, did I stuff up by syncing? I don't know how to go back to the previous state. Do I have to repeat the process? I have a feeling if other pull requests are accepted my 'after-sync' repository will not have an error anymore? :S

makermelissa commented 9 months ago

No, it's not you. Looks like #750 is holding things up. Since the author is not fixing the issue, I'll go ahead and get both that one and this finished up.

KingPharoo commented 9 months ago

Thank you so much! :D

KingPharoo commented 9 months ago

Hello

I just installed blinka on a new board and I am hit with "NotImplementedError: Board not supported OLIMEX_LIME2." error. I installed using sudo pip install Adafruit-Blinka.

Is the merge request still needed to go live or something? again I am new, so I am not sure. Platform detect seems good.

makermelissa commented 9 months ago

Ah sorry, it was because I hadn't done a release. I just created a release (8.27.0), which should be available in a few minutes.