search

adafruit / Adafruit_Blinka_Displayio

Displayio for Blinka
MIT License
14 stars 20 forks source link

Initial implementation of I2CDisplay for Blinka #58

Closed lesamouraipourpre closed 3 years ago

lesamouraipourpre commented 3 years ago

This PR collects the suggestions of @eteq and @wolfmanjm from PR #41.

I have (minimally) tested on a Raspberry Pi 3 and it works. It could do with being tested on other Blinka devices.

lesamouraipourpre commented 3 years ago

The autodoc_mock_imports line was unnecessary. Somehow my virtual environment had become corrupted. Tested by creating a new virtual environment and re-cloning my repo.

makermelissa commented 3 years ago

Ok, once https://github.com/adafruit/Adafruit_Blinka/pull/488 is merged in and a newer version of Blinka is released, we can re-run this and the checks should pass.

makermelissa commented 3 years ago

It's possible that it may not like microcontroller.Pin anyways since it is just passing, so I may need to create a generic pin class for sphinx. In that case, adding microcontroller to autodoc_mock_imports makes sense.