search

adafruit / Adafruit_Blinka_Displayio

Displayio for Blinka
MIT License
14 stars 20 forks source link

Prepare for the removal of the max_size parameter from displayio.Group #68

Closed lesamouraipourpre closed 3 years ago

lesamouraipourpre commented 3 years ago

Reference #67

The parameter is still allowed but will print a deprecation warning and ignore it internally. The intention is too allow the parameter to be passed for a while until after CircuitPython 7 is released and then remove it completely. The change in this PR is not a breaking changing.

The documentation now builds entries for the classes within displayio.

tannewt commented 3 years ago

FYI I've regretted printing a notice when something is deprecated. When I added one, it was triggered by a library that end users didn't have control over. I'd recommend removing it.

makermelissa commented 3 years ago

Good point. I remember that happening with the requests library.