search

adafruit / Adafruit_Blinka_bleio

`_bleio` for Blinka based on `bleak`
58 stars 19 forks source link

Add device name to advertisement data that is passed back. #13

Closed dhalbert closed 4 years ago

dhalbert commented 4 years ago

The device name was omitted from the synthetic advertisement data created from ScanEntry objects. We need the name to recognize some devices, such as BerryMed pulse oximeters.

In some cases an artificial name, either "Unknown" or a human-readable hex address, is passed back from bleak or the libraries that bleak calls. Find these and discard them.

ladyada commented 4 years ago

how do u want me to test?

dhalbert commented 4 years ago

@ladyada Assuming you still have the repos and pip3 installs from the previous testing on Windows:

git pull https://github.com/dhalbert/Adafruit_Blinka_bleio
git checkout adv-name
# This should already be installed, so should not be necessary
# pip3 install -e adafruit-blinka-bleio
git clone https://github.com/adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter
pip3 install -e adafruit-circuitpython-ble-berrymed-pulse-oximeter
py Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter\examples\ble_berrymed_pulse_oximeter_simpletest.py