Closed alexwhittemore closed 3 years ago
I agree with those points. My thought AGAINST doing it that way is simply that bleak vs hcitool have significantly-enough different behavior in how they yield advertisements that code designed to rely on one vs the other is not totally cross-compatible. In fact, the purpose of the addition is so that I can set a "use hcitool" flag and have the code explicitly error if hcitool isn't installed or configured right. An environment variable seems a little farther away from where I made that decision in code.
It also doesn't make a ton of difference to me - I can refactor around an environment variable instead of an instance var.
Fixes #19, kind of. There's no even kind of clean way to make a proper API for switching manually between the bleak and hcitool backends, so for now I've just made a note in the readme.