search

adafruit / Adafruit_Blinka_bleio

`_bleio` for Blinka based on `bleak`
58 stars 19 forks source link

common.py throws a FutureWarning from bleak call to get_discovered_devices #41

Closed MrYsLab closed 1 year ago

MrYsLab commented 2 years ago

When calling the bleak scanner method, _get_discovereddevices, a future warning is thrown. Please update by using the bleak _discovereddevices property as suggested in the warning.

MrYsLab commented 2 years ago

@tekktrik, I must be missing something. I don't see any changes to common.py or a separate branch. Could you please explain why this issue is closed if there are no changes? Thanks.

tekktrik commented 2 years ago

Hi @MrYsLab, the issue is still open, I just had opened a PR for this issue because I thought it would be simpler than it was. Right now the library is pinning the version of bleak so it'd need to be re-pinned to a more updated version I believe. I've left the issue open in that case.

tekktrik commented 2 years ago

@makermelissa is there any plan or benefit to upgrading bleak at some point? That would allow for resolving this issue.

makermelissa commented 2 years ago

@tekktrik I'm not sure. @tannewt and @dhalbert did a bunch of the work on this one. Maybe one of them can chime in.