search

adafruit / Adafruit_Blinka_bleio

`_bleio` for Blinka based on `bleak`
58 stars 19 forks source link

Improved Typing #43

Closed davclark closed 1 year ago

davclark commented 2 years ago

As of today, installing the requirements in python 3.9.11 on Linux (Kubuntu 21.10) plus mypy, and running mypy _bleio yields 58 errors.

@dhalbert pointed me to the C bindings: https://github.com/adafruit/circuitpython/tree/main/shared-bindings/_bleio

FoamyGuy commented 2 years ago

The specific mypy errors that we are interested in knocking out with our first round of effort are the "Function is missing a type annotation" from the --disallow-untyped-defs flag

mypy can flag other things as well but we're trying to get the bulk of those missing typing altogether done and then eventually down the line we may add mypy checks to the actions CI and at that time we'll figure out the configuration to use which will affect which specific errors end up getting flagged for us.

dhalbert commented 1 year ago

Fixed by #44.