search

adafruit / Adafruit_Blinka_bleio

`_bleio` for Blinka based on `bleak`
58 stars 19 forks source link

Added 32-bit UUID support. #62

Closed anthonytw closed 1 year ago

anthonytw commented 1 year ago

Previously the library only supported 16-bit standard UUID, but the spec allows for 32-bit UUIDs as well. Encountering a 32-bit UUID caused the code to raise an exception. This fix adds support for 32-bit standard UUIDs.

Resolves #61

dhalbert commented 1 year ago

Hi, check the build log for pylint complaints: https://github.com/adafruit/Adafruit_Blinka_bleio/actions/runs/4761020028/jobs/8461884121?pr=62

You can use pre-commit to run these checks locally: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

anthonytw commented 1 year ago

I'll look at the complaints, thanks for mentioning the pre-commit option, I've not used that before. I'll recommit in a bit.

anthonytw commented 1 year ago

Okay, looks like that worked. Sorry the change is a bit larger now, I had to restructure things a bit to get it to stop complaining about "too many branches".