adafruit / Adafruit_BluefruitLE_nRF51

Arduino library for nRF51822-based Adafruit Bluefruit LE modules
197 stars 122 forks source link

Moved to actions, no doxygen #55

Open evaherrada opened 4 years ago

evaherrada commented 4 years ago

@ladyada Same here. Should I include the dependencies only used in examples in library.properties?

ladyada commented 4 years ago

yeah - some folks complain but for the vast majority its helpful!

evaherrada commented 4 years ago

@ladyada Also, should I not test the esp32 and nrf52 on this library? The esp32 is missing softwareserial and the nrf52 is just failing because some stuff is being redefined

PaintYourDragon commented 4 years ago

I’d suggest building for SAMD only. Maybe even just specific boards…Circuit Playground Express and try Metro M0 or something? The mentions of Serial1 and Wire1 imply post-AVR boards, and the PLL stuff is very device specific.