adafruit / Adafruit_CircuitPlayground

library for Circuit Playground board
171 stars 77 forks source link

bug in Adafruit_CPlay_Speaker::set() #34

Closed manitou48 closed 5 years ago

manitou48 commented 6 years ago

in Adafruit_CPlay_Speaker::set() in Adafruit_CPlay_Speaker.cpp, i believe TCCR4A = value; should be changed to OCR4A = value;

Also in talkie.cpp in Adafruit_CPlay_Speaker::say() change TCCR4A = 0x7F; to OCR4A = 0x7F;

ladyada commented 6 years ago

we'll take a look at this too!

mike2nl commented 5 years ago

@ladyada how is the status on that because i will do some game things with sound.

ladyada commented 5 years ago

@mike2nl hiya - whats not working?

ladyada commented 5 years ago

@mike2nl ^

PaintYourDragon commented 5 years ago

Quite right, fixed in 1.8.3 release now, thanks for spotting that!