search

adafruit / Adafruit_CircuitPlayground

library for Circuit Playground board
171 stars 77 forks source link

Preprocessor mismatch for CPX #44

Closed caternuson closed 4 years ago

caternuson commented 4 years ago

Re this thread: https://forums.adafruit.com/viewtopic.php?f=58&t=157171

Simple issue. Just some preprocessor stuff.

Recent updates added #if that uses __SAMD21__ https://github.com/adafruit/Adafruit_CircuitPlayground/blob/f2b5e28023c81321a477ec06b4ccc3a43624fe44/Adafruit_CircuitPlayground.cpp#L53 vs. BSP which uses __SAMD21G18A__ https://github.com/adafruit/ArduinoCore-samd/blob/a6e9eb3686c0899221d2f81829f0b267b2e69240/boards.txt#L184 so pulldown/ups aren't being engaged.

ladyada commented 4 years ago

oof sorry about that - i tested CPB the most... could you submit a PR? im a bit swamped today :)

caternuson commented 4 years ago

Fixed with #45