search

adafruit / Adafruit_CircuitPlayground

library for Circuit Playground board
171 stars 77 forks source link

No implementation for sendRAW #59

Open idankri opened 3 years ago

idankri commented 3 years ago

Hi! I noticed there is no implemented support for sending raw IR data. The relevant function is written in IRLib_HashRaw.h, which had no include statement in IRLibCPE.h, and in addition the only linkage was broken: The next line is a line is in IRLib_HashRaw.h:

define IR_SEND_RAW case 0: IRsendRaw::send((uint16_t*)data,data2,khz); break;

The IR_SEND_RAW macro is used in IRLibCombo.h in IRsend class, in the send method, in order to send raw transmission. That will always result as an illegal cast between uint32_t to uint16_t* . As a result it's impossible to use this method from the built-in IRsend object in the main object of CircuitPlayground. I submitted PR of how I think this should be implemented. Hope that helps :) Idan

ladyada commented 3 years ago

thanks! it may be a bit till we get to this PR as we have a lot of pending bug fixes to check - your PR is appreciated!