search

adafruit / Adafruit_CircuitPlayground

library for Circuit Playground board
171 stars 77 forks source link

Avoid unused parameter warning #64

Closed henrygab closed 3 years ago

henrygab commented 3 years ago

GCC catches this:

...\utility\IRLibRecvBase.cpp:
      In function 'void IRLib_IRrecvComplete(uint8_t)':
...\utility\IRLibRecvBase.cpp:
      Line 161 Char 35
      warning: unused parameter 'Reason' [-Wunused-parameter]
  161 | void IRLib_IRrecvComplete(uint8_t Reason) {
      |                           ~~~~~~~~^~~~~~
henrygab commented 3 years ago

@hathach - Another super-simple one, if you'd open to merging?

ladyada commented 3 years ago

@henrygab please do not tag people

henrygab commented 3 years ago

I apologize. I did not realize this would be viewed negatively, and did not intend to offend.

ladyada commented 3 years ago

all good - trying to keep volunteer's inboxes sane :)

evaherrada commented 3 years ago

@henrygab It's totally fine. People like myself have recent contributions to just about every CircuitPython library so there are many times when even though it may look like I've contributed to it a lot, I haven't ever even looked at the code itself.