search

adafruit / Adafruit_CircuitPython_24LC32

CircuitPython Driver for Adafruit 24LC32 I2C EEPROM Breakout 32Kbit / 4 KB
MIT License
6 stars 6 forks source link

Disable f-string warning in .pylintrc #19

Closed tekktrik closed 2 years ago

tekktrik commented 2 years ago

New black version didn't want the f-strings, and this library is used widely enough that it does need to be

kattni commented 2 years ago

This should be disabled in the .pre-commit-config.yaml file, not .pylintrc.

On Tue, Mar 29, 2022, 20:58 tekktrik @.***> wrote:

@tekktrik https://github.com/tekktrik requested review from @adafruit/circuitpythonlibrarians on: #19 https://github.com/adafruit/Adafruit_CircuitPython_24LC32/pull/19 Disable f-string warning in .pylintrc.

— Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_CircuitPython_24LC32/pull/19#event-6330922200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4AGATBF22PTMG4CORR76DVCORJVANCNFSM5SAHHDGA . You are receiving this because your review was requested.Message ID: <adafruit/Adafruit_CircuitPython_24LC32/pull/19/issue_event/6330922200@ github.com>

tekktrik commented 2 years ago

It looks like it is though, unless I'm not understanding correctly

tekktrik commented 2 years ago 
        args: ['([[ ! -d "examples" ]] || for example in $(find . -path "./examples/*.py"); do pylint --disable=missing-docstring,invalid-name,consider-using-f-string $example; done)']
tekktrik commented 2 years ago

Never mind, those are the examples

tekktrik commented 2 years ago

Closing in favor of #20