search

adafruit / Adafruit_CircuitPython_APDS9960

Adafruit Bundle driver for APSD9960 Gesture breakout board
MIT License
11 stars 17 forks source link

Remove unused interrupt pin arg and doc updates #34

Closed fivesixzero closed 3 years ago

fivesixzero commented 3 years ago

Addresses #33 with some minor doc updates for good measure.

These changes don't have any effect on the example code or the function of the library. The only thing that the incoming interrupt_pin arg used to do was to set an internal variable that was never actually used.

An alternative approach would be to update the doc to indicate that we want a DigtalInOut rather than a Pin. Given that it isn't used, I've started with this PR. Feel free to reject the PR if this approach isn't appropriate. :)

fivesixzero commented 3 years ago

Should be ready for review now that I've tidied up the typos and linter errors. :)

fivesixzero commented 3 years ago

For good measure I double-checked the APDS9960 Learn Guide CircuitPython page.

The interrupt features aren't mentioned in there and the examples don't make use of the interrupt_pin argument. So this change won't cause problems there.