adafruit / Adafruit_CircuitPython_AdafruitIO

Adafruit IO for CircuitPython
http://io.adafruit.com
MIT License
49 stars 33 forks source link

IO_HTTP: Support creating group data with `send_group_data` #124

Closed tyeth closed 1 month ago

tyeth commented 1 month ago

Fixes #97

@brentru as mentioned in discord, I had a quick look at this while in the codebase, and this seemed reasonable. I also fixed the path for send_batch_data. That then lead me to poke my nose in and test batch method (requiring from collection import namedtuples), I'll leave that for now

github-actions[bot] commented 1 month ago

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

tyeth commented 1 month ago

Just a note that it occurred to me to test the created_at field from device (failed due to RTC not set) so I moved to using io.receive_time(), which I then thought to test from another country with crazier time zone offset (NZ) which failed.

I've therefore added an optional timezone argument to the receive_time method and updated the demo to use it. Tested tz argument to integration with GB and UTC, blank string didn't work (therefore we only add the tz argument if necessary)