search

adafruit / Adafruit_CircuitPython_AdafruitIO

Adafruit IO for CircuitPython
http://io.adafruit.com
MIT License
49 stars 33 forks source link

Allow underscores in adafruit IO feed keys #82

Closed Neradoc closed 2 years ago

Neradoc commented 2 years ago

The Adafruit IO site allows underscores in the feed key, but the library doesn't. Am I missing something, or should it be allowed ?

https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/4b4db6f3f81e5c860af4b500717945cc5dd2b044/adafruit_io/adafruit_io.py#L43-L45

brentru commented 2 years ago

EDIT:

A Feed Key MAY ONLY contain lower case ASCII letters, numbers, and the dash character ("-").
DJDevon3 commented 2 years ago

According to the learn guide feed keys may only contain a dash. I ran into this recently too trying to figure out a connection issue to find out the feed name and key must be different. It’s wasn’t a problem after I understood the naming and key generation convention. https://learn.adafruit.com/naming-things-in-adafruit-io/the-two-feed-identifiers

This seems more like an AdafruitIO policy stance associated with regex and key generation. If that’s what they say they need then everyone can get along without underscores no problem. It’s a trivial inconvenience.

brentru commented 2 years ago

@Neradoc The Adafruit IO site does not allow underscores in the feed key, @DJDevon3 is correct. It should not be allowed by this library.

A Feed Key MAY ONLY contain lower case ASCII letters, numbers, and the dash character ("-").