search

adafruit / Adafruit_CircuitPython_AdafruitIO

Adafruit IO for CircuitPython
http://io.adafruit.com
MIT License
49 stars 33 forks source link

send_batch_data requires class instances when it should just require accept a list or dict #94

Closed evaherrada closed 1 month ago

evaherrada commented 2 years ago

https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/main/adafruit_io/adafruit_io.py#L607

The _asdict method needs to be run on an instance of a class to get the class attributes. It would be easier for most users to just send a list or dict.

evaherrada commented 2 years ago

cc @brentru

brentru commented 2 years ago

@evaherrada Do you want to work on this issue next week? Tag me when there's a PR ready for review

rbrian commented 2 years ago

I’m available to help however I can, at the very least for testing.

tyeth commented 1 month ago

Closing this after merging #125 and releasing v5.9.0