search

adafruit / Adafruit_CircuitPython_AzureIoT

Access to Microsoft Azure IoT device, messaging, and job services from CircuitPython!
MIT License
20 stars 15 forks source link

add logging to requirements #29

Closed askpatrickw closed 3 years ago

askpatrickw commented 3 years ago

Many moons ago I did a PR to add adafruit_logging to the readme, this adds it to the requirements.txt

Also added .python_version to the .gitignore

brentru commented 3 years ago

@askpatrickw Hold on before merging. I removed Logging as a requirement to MiniMQTT in the latest release.

brentru commented 3 years ago

@askpatrickw I have it set up where you pass MiniMQTT a logger, you may want to duplicate this functionality here since this library uses MiniMQTT but does not expose it

Related API call: https://circuitpython.readthedocs.io/projects/minimqtt/en/latest/api.html#adafruit_minimqtt.adafruit_minimqtt.MQTT.enable_logger

askpatrickw commented 3 years ago

Can't do this anyway it isn't published on PyPi. https://github.com/adafruit/Adafruit_CircuitPython_Logging/blob/master/setup.py.disabled

That's a bigger problem.. I'll open a bug in Circup about that.