search

adafruit / Adafruit_CircuitPython_BLE

Bluetooth Low Energy (BLE) library for CircuitPython
MIT License
127 stars 58 forks source link

ble_hid_periph.py does not work for me #46

Closed kohlerm closed 4 years ago

kohlerm commented 4 years ago

https://github.com/adafruit/Adafruit_CircuitPython_BLE/blob/master/examples/ble_hid_periph.py does not work for me because the Keyboard constructor does not expect an argument. I checked the library and it does not seem to be support that argument. Anything I'm missing here?

kohlerm commented 4 years ago

Looks like the change to support the argument was reverted. Anyone knows why?

tannewt commented 4 years ago

Oops! I tested with a version I had changed. Here is a WIP branch: https://github.com/tannewt/Adafruit_CircuitPython_HID/tree/pass_in_devices

I'll test it after lunch and then make a PR if it all looks good. Thanks for filing an issue!

tannewt commented 4 years ago

PR pending here: https://github.com/adafruit/Adafruit_CircuitPython_HID/pull/43

tannewt commented 4 years ago

Confirmed ble_hid_periph.py works with it as well.

kohlerm commented 4 years ago

Great let me check that on the weekend :-)

tannewt commented 4 years ago

This is fixed by https://github.com/adafruit/Adafruit_CircuitPython_HID/pull/43