adafruit / Adafruit_CircuitPython_BLE_Eddystone

CircuitPython BLE library for Google's open "physical web" Eddystone.
MIT License
4 stars 10 forks source link

Minor tidying around use of Bluetooth Comany ID value #7

Closed kevinjwalters closed 4 years ago

kevinjwalters commented 4 years ago

I noticed:

kevinjwalters commented 4 years ago

Improvements around prefix feature in https://github.com/adafruit/Adafruit_CircuitPython_BLE/issues/82

dhalbert commented 4 years ago

I replaced prefix with match_prefixes in PR #8 in mid-June. How is the current code?

kevinjwalters commented 4 years ago

The current code does use match_prefixes. I'd only looked at the issue tickets and assumed incorrectly that hadn't been updated.

dhalbert commented 4 years ago

Thanks, I'll close this. I should have noticed this issue was addressed by #8. We deliberately don't ID the company ID, to avoid appearing like an official Google product thing.

Fixed by #8.