search

adafruit / Adafruit_CircuitPython_BME680

CircuitPython driver for BME680
MIT License
57 stars 41 forks source link

Gas resistance calculation showing incorrect results for BME688 #42

Closed Technodad closed 2 years ago

Technodad commented 3 years ago

While the BME680 library is recommended for the BME688, it appears the calculations for gas resistance are different for the two sensors per @adafruit_support_carter in this support forum thread post on July 13.

Suggest either splitting the 688 into its own library, or adding logic to the combined library to detect the chip type and use the appropriate calculation. The former will save a bit on library size, but would require the BME688 project pages to be updated.

ladyada commented 3 years ago

yeah there's no way to detect between the chips that we found so we'll have to just make a subclass or yeah maybe a new library

@caternuson wanna avoid pn532 and look at this instead

caternuson commented 3 years ago

@ladyada yep. bme688 in hand and taking a look.

caternuson commented 2 years ago

Should be fixed with #43 and release in 3.4.0: https://github.com/adafruit/Adafruit_CircuitPython_BME680/releases/tag/3.4.0