adafruit / Adafruit_CircuitPython_BME680

CircuitPython driver for BME680
MIT License
57 stars 41 forks source link

Add method to disable gas heater #64

Closed graeme-winter closed 1 year ago

graeme-winter commented 1 year ago

Setting either of temperature or heat time to zero will disable

Fixes adafruit/Adafruit_CircuitPython_BME680#63

tekktrik commented 1 year ago

Is this ready for review?

graeme-winter commented 1 year ago

I'll welcome some review comments, not had a chance to polish though

caternuson commented 1 year ago

I'd suggest using None to disable instead of 0. That'd be similar to what is done in the Motor library for disabling servo outputs: https://github.com/adafruit/Adafruit_CircuitPython_Motor/pull/27