Fix fusion modes - Githubissues

ViennaMike commented 3 years ago

Fixes issue #75 that I opened. When doing so, I found that the outputs mismatched what they should be for some additional modes as well, so I fixed them too:

Old code returned magnetometer values when in ACCONLY_Mode, fixed to add to excluded list
Old code only returned Euler angles, quaternions, linear acceleration, and gravity values when in absolute orientation fusion modes. They are also valid and should be returned for relative orientation fusion modes (IMUPLUS and M4G). Fixed.
The modes to output table in the comments was incomplete, as it did not list the relative orientation fusion modes. I added that column, clarified the language, and added a reference to the table in the datasheet to help maintainers and users.

ViennaMike commented 3 years ago

My first time making a proposed change. When I look into the checks, the only details I see are "Consider using a generator instead 'tuple" for lines I haven't changed. If I need to change something, let me know what's needed. Thanks!

evaherrada commented 3 years ago

@ViennaMike Yeah, so that's a check that recently got added to pylint. I'll fix that for you since it's something that I should have done anyway and then just run black.

If you do want to learn more about pylint and black go here: https://learn.adafruit.com/improve-your-code-with-pylint

ViennaMike commented 3 years ago

Thanks, I figured it was just that, but I wasn't sure and didn't want to mess with lines of code I wasn't that familiar with. I'll use the new master and generate a new pull request for adding the ability to do an Axis remap (see Section 3.4 of the data sheet) later this week, as I think it would be useful to a lot of people.

On Tue, Apr 6, 2021 at 4:53 PM Dylan Herrada @.***> wrote:

@ViennaMike https://github.com/ViennaMike Yeah, so that's a check that recently got added to pylint. I'll fix that for you since it's something that I should have done anyway and then just run black.

If you do want to learn more about pylint and black go here: https://learn.adafruit.com/improve-your-code-with-pylint

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_CircuitPython_BNO055/pull/76#issuecomment-814433409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHXZ3UCKLGJTQQXBANA3C3THNYEVANCNFSM42JPSM4A .

evaherrada commented 3 years ago

No problem. Sweet. That sounds like a great addition.

adafruit / Adafruit_CircuitPython_BNO055

Fix fusion modes #76