search

adafruit / Adafruit_CircuitPython_BusDevice

Two helper classes that handle transaction related state for I2C and SPI including locks.
MIT License
108 stars 76 forks source link

Example should be renamed to include simpletest #31

Closed kattni closed 5 years ago

kattni commented 5 years ago

Example busdevice_read_register_i2c.py could be renamed to busdevice_read_register_i2c_simpletest.py to match CircuitPython library standards.

The lines including this file name in the docs/examples.rst file must also be updated to reflect the name change, e.g.:

.. literalinclude:: ../examples/current_file_name.py
    :caption: examples/current_file_name.py
    :linenos:

would be updated to:

.. literalinclude:: ../examples/current_file_name_changed.py
    :caption: examples/current_file_name_changed.py
    :linenos:
huyle1097 commented 5 years ago

Hi @kattni I have already made PR for this issue. Could you please review it and let me know if there is any problem? Thank you.

tannewt commented 5 years ago

Fixed by #32. Thank you @huyle1097