search

adafruit / Adafruit_CircuitPython_BusDevice

Two helper classes that handle transaction related state for I2C and SPI including locks.
MIT License
105 stars 76 forks source link

removed comma on line 113 in i2c_device.py #57

Closed phil-shenk closed 4 years ago

phil-shenk commented 4 years ago

This comma was throwing a syntax error for us (python 3.5), removing this comma fixed it

jerryneedell commented 4 years ago

Just a question -- if I run black, with out the --python35, then presumably, it will insert the comma, correct? If then commit the PR, will it fail in CI or will --python35 accept it with the comma thus setting up a case that may fail for some users....if they use python 3.5 My point it is, I have tended to just run black without the --python35 tanking it would "do no harm" to use a higher version. Is this incorrect?

Nevermind -- I think it will fail in CI since black --python35 will say it is not properly formatted. That is my clue to remember to usr the --python35 setting