search

adafruit / Adafruit_CircuitPython_CircuitPlayground

CircuitPython library for Circuit Playground Express
MIT License
91 stars 71 forks source link

CP: more configuration options for the tap detection #99

Closed mw46d closed 3 years ago

mw46d commented 3 years ago

The CircuitPython code did not allow me to configure the tap detection for what I needed:-( This pull request was updated to master! My test system was actually CircuitPython 6.0.1 on a CPX, the the master/beta branch of CircuitPython did not seem to work well on that board:-( I'm not really particular about the method name or anything. But I could not find a compatible way to extend the property setter:-(

kattni commented 3 years ago

@mw46d Can you post your test code here? I'd really appreciate it.

kattni commented 3 years ago

@mw46d Apologies for the delay. I have been pulled into a high priority project that I need to get through before I can circle back to this. I will get to it as soon as possible. I took care of a merge conflict from an update we applied to the library, hopefully everything still passes with the conflict resolution.

kattni commented 3 years ago

It failed. The issue is that the latest version of black needs to be run on the circuitplayground_base.py file, and those changes pushed. @mw46d If this is not something you're familiar with or comfortable with, I'll take care of it when I circle back to review. Otherwise, if you are comfortable with it, feel free to run black and push the changes to this PR.