jepler
commented
3 months ago I intended to say that "from typing import Union" will raise an ImportError exception on any CircuitPython version, causing the protection against future planned changes to CircuitPython (in which displayio.FourWire etc are removed) to no loger work as intended.
I regret that what I wrote had the alternate interpretation "this code can't even work under any circumstances", because that got us off on the wrong foot.
At the risk of over-explaining: The first ImportError exception means that the subsequent line "from busdisplay import BusDisplay" will never be used, and the interpreter will jump down to "from displayio import FourWire", always using the old compatibility names to be used. This will run on any current CircuitPython version, because both the old and new names are available right now, but will fail once the old displayio.FourWire name is removed in CircuitPython 10.
You can see what I mean by running this block of code:
try:
from os import ThisDoesNotExist
print("this will not print, as this code is not used")
except ImportError:
print("the first ImportError exception jumped to this except block")I've asked other CircuitPython librarians to review this PR so that someone else has the chance to vet and clarify what I'm saying and correct me if I'm mistaken.
EAGrahamJr
dhalbert
tannewt
Fixes #16 by adding the same constructs as found in SSD1306.