clip glyphs that exceed ascent property

adafruit / Adafruit_CircuitPython_Display_Text

Library to display text using displayio

MIT License

57 stars 38 forks source link

clip glyphs that exceed ascent property #130

Closed kmatch98 closed 3 years ago

kmatch98 commented 3 years ago

For font files that have ASCENT/DESCENT that is incompatible with the glyph dimensions and y-offsets, this clips the top of any offending glyphs and provides a warning.

This is to resolve https://github.com/adafruit/Adafruit_CircuitPython_Display_Text/issues/129

kmatch98 commented 3 years ago

This failed the "similar lines" pylint error. @foamyguy or @kattni, can you help install the proper incantations to clear that hurdle.

FoamyGuy commented 3 years ago

@kmatch98 if you merge adafruit/master into kmatch98/master and push the commits I think this PR will pass the actions.

I tested locally and the merge went smoothly with no conflicts. I think I can push it as well and save you the time if you'd like.

kmatch98 commented 3 years ago

Done. Should be good to go. Thanks for the refactor that made this one go smoothly.