Add _pixelbuf support - Githubissues

adafruit / Adafruit_CircuitPython_DotStar

Dotstarrin' away in CircuitPython land

MIT License

46 stars 38 forks source link

Add _pixelbuf support #42

Closed rhooper closed 4 years ago

siddacious commented 4 years ago

@rhooper Since pypixelbuf and the API changes were both merged, is this no longer WIP and ready to merge? I took a look and it's good from what I can tell but it may be wise to have someone more familiar with the code. In the meanwhile I'll do some testing

rhooper commented 4 years ago

This is no longer a wip

siddacious commented 4 years ago

Before someone else merges, might be worth mentioning this issue in the NeoPixel repo that popped up: https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel/issues/65 I'm not sure how similar the DotStar implementation is to the NeoPixel one but perhaps DotStar has the same issue?